This repository was archived by the owner on Dec 9, 2024. It is now read-only.
Fix payload normalization in http.request events. Closes #434 #459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #459 +/- ##
=========================================
+ Coverage 66.06% 66.17% +0.1%
=========================================
Files 32 32
Lines 1877 1883 +6
=========================================
+ Hits 1240 1246 +6
Misses 585 585
Partials 52 52
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Closes #434
How did you implement it:
When we moved from HTTP event to http.request event as CloudEvent the normalization need to happen also for the Body in the event
Todos:
Is this ready for review?: YES
Is it a breaking change?: NO