Skip to content
This repository was archived by the owner on Dec 9, 2024. It is now read-only.

Conversation

@mthenw
Copy link
Contributor

@mthenw mthenw commented May 24, 2018

What did you implement:

This PR removes some remaining code regarding invoke event handling.

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: Yes
Is it a breaking change?: Yes

@mthenw mthenw requested a review from RaeesBhatti May 24, 2018 13:00
@codecov
Copy link

codecov bot commented May 24, 2018

Codecov Report

Merging #432 into master will increase coverage by 0.59%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #432     +/-   ##
=========================================
+ Coverage   63.89%   64.49%   +0.6%     
=========================================
  Files          30       30             
  Lines        1681     1639     -42     
=========================================
- Hits         1074     1057     -17     
+ Misses        563      538     -25     
  Partials       44       44
Impacted Files Coverage Δ
event/event.go 77.41% <ø> (ø) ⬆️
internal/cache/subscription_cache.go 86.15% <ø> (-2.88%) ⬇️
router/router.go 55.83% <ø> (+3.68%) ⬆️
internal/cache/target.go 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c5a6b5...01b1a0f. Read the comment docs.

Copy link
Contributor

@RaeesBhatti RaeesBhatti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mthenw mthenw merged commit d710407 into master May 24, 2018
@mthenw mthenw deleted the remove-invoke branch May 24, 2018 13:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants