This repository was archived by the owner on Dec 9, 2024. It is now read-only.
Use Content-Type application/cloudevents+json for http provider #415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #415 +/- ##
=======================================
Coverage 63.85% 63.85%
=======================================
Files 29 29
Lines 1649 1649
=======================================
Hits 1053 1053
Misses 553 553
Partials 43 43
Continue to review full report at Codecov.
|
mthenw
approved these changes
Apr 27, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
For the
httpfunction provider, I changed theContent-Typeof the outgoing request toapplication/cloudevents+json. This is in accordance with the CloudEvents spec.Todos:
Is this ready for review?: YES
Is it a breaking change?: NO