This repository was archived by the owner on Dec 9, 2024. It is now read-only.
Require CloudEvents Source be a URI #414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #414 +/- ##
=======================================
Coverage 63.85% 63.85%
=======================================
Files 29 29
Lines 1649 1649
=======================================
Hits 1053 1053
Misses 553 553
Partials 43 43
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Changed the validation requirement on the
Sourcefield of theEventstruct to require a URI, rather than a URL. This is according to the CloudEvents spec.How did you implement it:
Changed validation on
Sourcefromvalidate:"url,required"tovalidate:"uri,required".I also changed the test that checks that a valid CloudEvent is not transformed into a CloudEvent. I changed the test case's
sourceto be a URI rather than a URL so that we would catch this in the future.How can we verify it:
Emit an event in CloudEvents format that uses a URI (not URL) in the
sourceproperty. Make sure that it wasn't transformed into a CloudEvent.Todos:
Is this ready for review?: YES
Is it a breaking change?: NO