Skip to content
This repository was archived by the owner on Dec 9, 2024. It is now read-only.

Conversation

@ganeshvlrk
Copy link
Contributor

Add SubscriptionID parameter reference to Update Subscription

What did you implement:

Add SubscriptionID parameter reference to Update Subscription

How did you implement it:

Trivial change

How can we verify it:

N/A

Todos:

N/A

Is this ready for review?: YES
Is it a breaking change?: NO

Add SubscriptionID parameter reference to Update Subscription
@ganeshvlrk ganeshvlrk requested review from alexdebrie and mthenw April 25, 2018 22:34
@codecov
Copy link

codecov bot commented Apr 25, 2018

Codecov Report

Merging #413 into master will decrease coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #413      +/-   ##
==========================================
- Coverage   63.85%   63.61%   -0.25%     
==========================================
  Files          29       29              
  Lines        1649     1649              
==========================================
- Hits         1053     1049       -4     
- Misses        553      557       +4     
  Partials       43       43
Impacted Files Coverage Δ
router/router.go 56.62% <0%> (-1.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c00a99f...2cfe1b9. Read the comment docs.

Copy link
Contributor

@alexdebrie alexdebrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @ganeshvlrk.

@ganeshvlrk ganeshvlrk requested review from mthenw and removed request for mthenw April 26, 2018 01:04
@mthenw mthenw merged commit e3b1318 into master Apr 26, 2018
@mthenw mthenw deleted the minor-fix-openapi branch April 26, 2018 06:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants