This repository was archived by the owner on Dec 9, 2024. It is now read-only.
Minimalize Dockerfile #378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthenw
reviewed
Feb 28, 2018
Contributor
mthenw
left a comment
mthenw
left a comment
There was a problem hiding this comment.
What are the size benefits here comparing to old approach?
| RUN dep ensure | ||
| RUN go build -o event-gateway cmd/event-gateway/main.go | ||
|
|
||
| FROM alpine:3.6 |
Contributor
There was a problem hiding this comment.
You could just replace this part.
RaeesBhatti
force-pushed
the
minimalize-dockerfile
branch
from
9af7a1a to
c59ef84
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The building of the binary should be done on host. Go can build static binaries for any platform, so, why ship the whole build env with the application!