Improve function invocation error #377
Conversation
RaeesBhatti
changed the title
| if err != nil { | ||
| if awserr, ok := err.(awserr.Error); ok { | ||
| switch awserr.Code() { | ||
| case "AccessDeniedException": |
There was a problem hiding this comment.
@elsteelbrain I did it differently, please take a look
There was a problem hiding this comment.
Have you tested it?
function/function.go
Outdated
| return nil, &ErrFunctionError{err} | ||
| } | ||
| awslambda := lambda.New(awsSession) | ||
| awslambda := lambda.New(session.New(config)) |
There was a problem hiding this comment.
This is deprecated!
| if err != nil { | ||
| if receivedAWSErr, ok := err.(awserr.Error); ok { | ||
| switch receivedAWSErr.Code() { | ||
| if awserr, ok := err.(awserr.Error); ok { |
There was a problem hiding this comment.
awserr collides with an imported package
There was a problem hiding this comment.
If there is no automated check for that (with gometalinter) I would assume it's fine.
There was a problem hiding this comment.
My linter is reporting a warning on this. Not that it would be problematic, just that it is bad practice.
There was a problem hiding this comment.
There are many places like that in the codebase. We can fix it but in separate PR, and it has to be automatically checked by gometalinter. AFAIR there is a check for that in gometalinter. Because of some reason, it has been turned off.
2 participants
No description provided.