Removed allocations for timestamp#121
Merged
Merged
Conversation
Member
|
Hi @epeshk, thanks for sending this, looks like a fantastic improvement 👍
Console.WriteLine("{0:----------------------------------------------}", DateTimeOffset.Now);I think it's fine to apply a limitation like "format strings can't result in more than 36 chars" but perhaps this could be documented using a constant and a unit test, so that we can be sure if a format string ends up producing output longer than what we'd expect, the results are reasonable? Definitely in favor of this change otherwise 👍 |
Member
|
Reading the code again, I see that we should fall through and still create correct output in the "too long" case - think it just needs a test :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to serilog/serilog#2094
Removed allocations from
DateTimeOffset.ToStringby usingISpanFormattable.TryFormatAPIBefore
After