SelfMetrics#2237
Merged
Merged
Conversation
nblumhardt
commented
May 21, 2026
|
|
||
| _sink.Emit(logEvent); | ||
|
|
||
| SelfMetrics.PipelineEventEmitted.Add(1); |
Member
Author
There was a problem hiding this comment.
Doing this after the Emit call avoids adding latency. It's not really going to be significant for a (non-observable) counter, just good hygiene.
nblumhardt
marked this pull request as draft
May 21, 2026 01:00
This comment was marked as resolved.
This comment was marked as resolved.
nblumhardt
marked this pull request as ready for review
May 21, 2026 01:20
Merged
This was referenced Jul 10, 2026
This was referenced Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
System.Diagnostics.Metricsis a nice low-cost way to surface things like the logging failure rate without the overhead and risk of actually sendingSelfLogoutput somewhere.This PR adds four metrics, which I might as well let describe themselves:
Here's what collecting a few of them with
dotnet counterslooks like:Tagging etc. is very conservative and should work with pretty much any downstream metrics system.
Addcalls adds more lines of code that don't really pull their weight in the kind of usage expected in this codebase.Performance
The most important benchmark this one touches is
PipelineBenchmark, which shows barely any change (the regression is within the range of run-to-run variations on this workstation).mainThis PR