Avoid using deprecated Buffer constructor#1510
Merged
Merged
Conversation
safe-buffer is already used and provides Buffer.alloc polyfill, so just use Buffer.alloc directly to avoid hitting deprecated API. Refs: https://nodejs.org/api/deprecations.html#deprecations_dep0005_buffer_constructor
Codecov Report
@@ Coverage Diff @@
## master #1510 +/- ##
=======================================
Coverage 79.04% 79.04%
=======================================
Files 21 21
Lines 940 940
Branches 170 170
=======================================
Hits 743 743
Misses 197 197
Continue to review full report at Codecov.
|
Member
|
That's the only place? Perfect 👌 |
Contributor
Author
|
@reconbot Yes, this has been done before in 5f53a45 but slipped in again in e8d9d2b due to a linter issue. See mysticatea/eslint-plugin-node#110 for context. |
oteku
pushed a commit
to Cutii/node-serialport
that referenced
this pull request
Apr 9, 2018
safe-buffer is already used and provides Buffer.alloc polyfill, so just use Buffer.alloc directly to avoid hitting deprecated API. Refs: https://nodejs.org/api/deprecations.html#deprecations_dep0005_buffer_constructor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
safe-bufferis already used and providesBuffer.allocpolyfill, so just useBuffer.allocdirectly to avoid hitting deprecated API.Refs:
https://nodejs.org/api/deprecations.html#deprecations_dep0005_buffer_constructor
Tracking: nodejs/node#19079