This repository was archived by the owner on Jan 27, 2021. It is now read-only.
Merged
Conversation
Contributor
Author
|
May be we need to run benchmarks on travis ;) . |
Owner
|
@harikt Absolutely. With Travis CI we don't need to launch Docker. |
Owner
|
Thank you |
Contributor
Author
|
@sergeyklay this is not fully done or may be broken on docker. May be you need to verify the same . |
Contributor
Author
|
I actually noticed one thing. I have accidentally commited something that I have been trying to benchmark :P . I hope I can send a PR if I fix the same in the coming days. |
Owner
|
Don't worry 😉 Take your time. I'm ok with this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially fixed #10 .
The docker file need to be updated.
I am not familiar with it.
I think probably each repo should contain a separate docker file for the phalcon extension is not needed for the rest.