Skip to content

Add guild role member counts endpoint#3452

Merged
arqunis merged 1 commit into
serenity-rs:currentfrom
nwerosama:guild-role-member-counts
Dec 13, 2025
Merged

Add guild role member counts endpoint#3452
arqunis merged 1 commit into
serenity-rs:currentfrom
nwerosama:guild-role-member-counts

Conversation

@nwerosama

Copy link
Copy Markdown
Contributor

Recently introduced and documented: discord/discord-api-docs#8025

I did test the endpoint with an example bot. However, I'm not sure if HashMap is a good idea to use but I'm open to other options instead.

@github-actions github-actions Bot added the http Related to the `http` module. label Dec 12, 2025
@arqunis arqunis added enhancement An improvement to Serenity. discord feature Related to Discord's functionality. labels Dec 13, 2025

@arqunis arqunis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, I'm not sure if HashMap is a good idea to use but I'm open to other options instead.

The CommandData::resolved field is a collection of maps, for which we use HashMap. Should be appropriate here since the endpoint also returns a map.

@arqunis
arqunis merged commit e3873b1 into serenity-rs:current Dec 13, 2025
20 of 22 checks passed
@nwerosama
nwerosama deleted the guild-role-member-counts branch December 14, 2025 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

discord feature Related to Discord's functionality. enhancement An improvement to Serenity. http Related to the `http` module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants