Repository navigation
Use the already decoded query image in find - #1701
Merged
Merged
Conversation
Afloat16
force-pushed
the
fix/single-read-find-20261109
branch
from
November 9, 2026 12:24
ef2fcb1 to
83e1b37
Compare
Afloat16
force-pushed
the
fix/single-read-find-20261109
branch
from
November 9, 2026 12:46
83e1b37 to
5695078
Compare
Flask 3 supplies Werkzeug Headers to the API routes. Include that existing input alongside the dictionary used by gRPC in the validate annotation. Keep the optional header type under TYPE_CHECKING. Verified the six mypy errors on the unchanged base. With this annotation, all 144 source files pass mypy 1.14.1 under both Flask 3.1.3 and Flask 2.0.2. Pylint scores 10.00/10, the existing token-validation tests pass in both environments, and dictionary, Headers and EnvironHeaders checks cover valid, absent, invalid and disabled authentication.
Afloat16
force-pushed
the
fix/single-read-find-20261109
branch
from
November 9, 2026 12:57
5695078 to
54994c7
Compare
serengil
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What has been done
find loaded the query to validate it, then passed the original source back into face detection. A non-seekable stream was exhausted on the second read and URLs could be downloaded twice. Pass the validated BGR array into detection.
How to test
python -m unittest discover -s tests/unit -p test_single_read_find.pyThe focused regression passes on Python 3.12 and fails on master a8cee7b at the second stream read. It exercises the NPZ gallery, search and skip-detector paths with a stub decoder and model. No weights or native codec were used.