Repository navigation
Preserve false values for boolean options in the HTTP API - #1684
Merged
Merged
Conversation
serengil
approved these changes
Nov 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Form fields arrive as strings. Converting "false" with bool() enabled alignment, enforced detection, anti-spoofing, L2 normalization and similarity search whenever clients explicitly disabled these options. The HTTP routes now parse true/false and 1/0, retain JSON booleans and reject invalid values and non-object JSON bodies with a 400 response. Added regression tests. Python compilation and 20 isolated form-parser cases passed. Flask was unavailable locally, so the Flask integration tests still need CI execution.