Serialize unsized RefCell, Mutex and RwLock

ChayimFriedman2 · ChayimFriedman2 · commit be3c37eb8be6 · 2022-09-22T09:57:55.000+03:00
diff --git a/serde/src/ser/impls.rs b/serde/src/ser/impls.rs
@@ -522,7 +522,7 @@ where
     }
 }
 
-impl<T> Serialize for RefCell<T>
+impl<T: ?Sized> Serialize for RefCell<T>
 where
     T: Serialize,
 {
@@ -538,7 +538,7 @@ where
 }
 
 #[cfg(feature = "std")]
-impl<T> Serialize for Mutex<T>
+impl<T: ?Sized> Serialize for Mutex<T>
 where
     T: Serialize,
 {
@@ -554,7 +554,7 @@ where
 }
 
 #[cfg(feature = "std")]
-impl<T> Serialize for RwLock<T>
+impl<T: ?Sized> Serialize for RwLock<T>
 where
     T: Serialize,
 {
diff --git a/test_suite/tests/test_ser.rs b/test_suite/tests/test_ser.rs
@@ -13,7 +13,7 @@ use std::sync::atomic::{
     AtomicBool, AtomicI16, AtomicI32, AtomicI8, AtomicIsize, AtomicU16, AtomicU32, AtomicU8,
     AtomicUsize,
 };
-use std::sync::{Arc, Weak as ArcWeak};
+use std::sync::{Arc, Mutex, RwLock, Weak as ArcWeak};
 use std::time::{Duration, UNIX_EPOCH};
 
 #[cfg(unix)]
@@ -847,3 +847,39 @@ fn test_integer128() {
 
     assert_ser_tokens_error(&1u128, &[], "u128 is not supported");
 }
+
+#[test]
+fn test_refcell_dst() {
+    assert_ser_tokens(
+        &RefCell::new([true]) as &RefCell<[bool]>,
+        &[
+            Token::Seq { len: Some(1) },
+            Token::Bool(true),
+            Token::SeqEnd,
+        ],
+    );
+}
+
+#[test]
+fn test_mutex_dst() {
+    assert_ser_tokens(
+        &Mutex::new([true]) as &Mutex<[bool]>,
+        &[
+            Token::Seq { len: Some(1) },
+            Token::Bool(true),
+            Token::SeqEnd,
+        ],
+    );
+}
+
+#[test]
+fn test_rwlock_dst() {
+    assert_ser_tokens(
+        &RwLock::new([true]) as &RwLock<[bool]>,
+        &[
+            Token::Seq { len: Some(1) },
+            Token::Bool(true),
+            Token::SeqEnd,
+        ],
+    );
+}

Original file line number	Diff line number	Diff line change
`@@ -522,7 +522,7 @@ where`
`522`	`522`	`}`
`523`	`523`	`}`
`524`	`524`
`525`		`-impl<T> Serialize for RefCell<T>`
	`525`	`+impl<T: ?Sized> Serialize for RefCell<T>`
`526`	`526`	`where`
`527`	`527`	`T: Serialize,`
`528`	`528`	`{`
`@@ -538,7 +538,7 @@ where`
`538`	`538`	`}`
`539`	`539`
`540`	`540`	`#[cfg(feature = "std")]`
`541`		`-impl<T> Serialize for Mutex<T>`
	`541`	`+impl<T: ?Sized> Serialize for Mutex<T>`
`542`	`542`	`where`
`543`	`543`	`T: Serialize,`
`544`	`544`	`{`
`@@ -554,7 +554,7 @@ where`
`554`	`554`	`}`
`555`	`555`
`556`	`556`	`#[cfg(feature = "std")]`
`557`		`-impl<T> Serialize for RwLock<T>`
	`557`	`+impl<T: ?Sized> Serialize for RwLock<T>`
`558`	`558`	`where`
`559`	`559`	`T: Serialize,`
`560`	`560`	`{`