Skip to content

Switch serde dependency to serde_core #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dtolnay merged 1 commit into from
Sep 14, 2025
Merged

Switch serde dependency to serde_core #57

dtolnay merged 1 commit into from
Sep 14, 2025

Conversation

@dtolnay
Copy link
Member

@dtolnay dtolnay commented Sep 14, 2025

No description provided.

@dtolnay dtolnay merged commit abdc6e5 into master Sep 14, 2025
18 checks passed
@dtolnay dtolnay deleted the serdecore branch September 14, 2025 16:07
@abr-egn
Copy link

abr-egn commented Sep 15, 2025

I think this broke compilation in the 0.11.18 release - an empty project with a Cargo.toml of just

[package]
name = "serde-bytes-test"
version = "0.1.0"
edition = "2024"

[dependencies]
serde_bytes = "0.11.18"

fails to compile:

   Compiling serde_bytes v0.11.18
error[E0407]: method `visit_byte_buf` is not a member of trait `Visitor`
   --> /Users/abraham.egnor/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/serde_bytes-0.11.18/src/de.rs:160:13

At a guess, the [dependencies] lines for std and alloc should be updated to reference serde_core rather than serde?

@abr-egn abr-egn mentioned this pull request Sep 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dtolnay @abr-egn