Skip to content

Unconditional serde_bytes::deserialize #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dtolnay merged 1 commit into from
Dec 27, 2023
Merged

Unconditional serde_bytes::deserialize #47

dtolnay merged 1 commit into from
Dec 27, 2023

Conversation

@dtolnay
Copy link
Member

@dtolnay dtolnay commented Dec 27, 2023

This cfg is from back when deserialize had this signature, before 6a14f76, so it didn't make sense without Vec existing:

bytes/src/lib.rs

Lines 131 to 134 in 29f7e7a

#[cfg(any(feature = "std", feature = "collections"))]
pub fn deserialize<'de, T, D>(deserializer: D) -> Result<T, D::Error>
where T: From<Vec<u8>>,
D: Deserializer<'de>

@dtolnay dtolnay merged commit bd341f2 into master Dec 27, 2023
@dtolnay dtolnay deleted the nostd-deserialize branch December 27, 2023 02:13
@sosthene-nitrokey sosthene-nitrokey mentioned this pull request Dec 27, 2023
Closed
@dtolnay dtolnay linked an issue Dec 27, 2023 that may be closed by this pull request
#[serde(with = "serde_bytes")] does not work in no_std. #41
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

#[serde(with = "serde_bytes")] does not work in no_std.

2 participants

@dtolnay