Skip to content

Ensure pool uses existing client on a LIFO basis#11

Merged
sushantdhiman merged 2 commits intosequelize:masterfrom
peakon:fix/lifo
Jul 2, 2019
Merged

Ensure pool uses existing client on a LIFO basis#11
sushantdhiman merged 2 commits intosequelize:masterfrom
peakon:fix/lifo

Conversation

@holm
Copy link
Copy Markdown

@holm holm commented Jul 2, 2019

The documentation claimed that the pool was LIFO, but in practice it was not. I suspect this is the reason the pool grows more than required, as clients are constantly cycled through, and thus never reaches their idle time, unless usage essentially stops.

This should fix sequelize/sequelize#10907 and the original report in sequelize/sequelize#10902.

@sushantdhiman sushantdhiman merged commit 6e8c2fc into sequelize:master Jul 2, 2019
@sushantdhiman
Copy link
Copy Markdown
Collaborator

+ [email protected]

@sushantdhiman
Copy link
Copy Markdown
Collaborator

+ [email protected]

@holm
Copy link
Copy Markdown
Author

holm commented Jul 2, 2019

Thanks for the quick turnaround on this

@holm holm deleted the fix/lifo branch July 2, 2019 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Postgres Freeable Memory Leak with Sequelize v4.43.1 pg v7.9.0 and pg-hstore v2.3.2

2 participants