Ensure pool uses existing client on a LIFO basis#11
Merged
sushantdhiman merged 2 commits intosequelize:masterfrom Jul 2, 2019
Merged
Ensure pool uses existing client on a LIFO basis#11sushantdhiman merged 2 commits intosequelize:masterfrom
sushantdhiman merged 2 commits intosequelize:masterfrom
Conversation
added 2 commits
July 2, 2019 11:05
sushantdhiman
approved these changes
Jul 2, 2019
Collaborator
5 tasks
Collaborator
Author
|
Thanks for the quick turnaround on this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documentation claimed that the pool was LIFO, but in practice it was not. I suspect this is the reason the pool grows more than required, as clients are constantly cycled through, and thus never reaches their idle time, unless usage essentially stops.
This should fix sequelize/sequelize#10907 and the original report in sequelize/sequelize#10902.