Skip to content

Bring back quoteIdentifier(s) to queryInterface to ease migration to v6#13810

Merged
sdepold merged 4 commits intomainfrom
fix-12627
Dec 22, 2021
Merged

Bring back quoteIdentifier(s) to queryInterface to ease migration to v6#13810
sdepold merged 4 commits intomainfrom
fix-12627

Conversation

@sdepold
Copy link
Copy Markdown
Member

@sdepold sdepold commented Dec 22, 2021

Pull Request Checklist

Please make sure to review and check all of these items:

  • Have you added new tests to prevent regressions?
  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description Of Change

In some version of v6, the queryInterface apparently lost quoteIdentifier and quoteIdentifiers which is hindering people to update to v6 (#12627). Interestingly, the types haven't been updated accordingly. So there is a certain discrepancy. This PR is recovering the methods.

Comment thread lib/dialects/abstract/query-generator.js
Comment thread types/lib/query-interface.d.ts
Comment thread types/lib/query-interface.d.ts
@sdepold sdepold merged commit 001dc60 into main Dec 22, 2021
@sdepold sdepold deleted the fix-12627 branch December 22, 2021 12:50
@github-actions
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 6.12.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

aliatsis pushed a commit to creditiq/sequelize that referenced this pull request Jun 2, 2022
…sequelize#13810)

* fix(query-generator): update documentation of quoteIdentifier(s)

* fix(query-interface): bring back quoteIdentifier(s) to queryInterface

* fix(formatting): fix linting of class-to-invokable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants