fix(13804): use schema for ARRAY(ENUM) type name#13807
Merged
sdepold merged 3 commits intosequelize:mainfrom Dec 22, 2021
Merged
fix(13804): use schema for ARRAY(ENUM) type name#13807sdepold merged 3 commits intosequelize:mainfrom
sdepold merged 3 commits intosequelize:mainfrom
Conversation
WikiRik
added
dialect: postgres
WikiRik
requested changes
Dec 21, 2021
Member
WikiRik
left a comment
WikiRik
left a comment
There was a problem hiding this comment.
I believe your new test is not correct, can you check?
WikiRik
approved these changes
Dec 21, 2021
sdepold
approved these changes
Dec 22, 2021
Member
|
thx! |
4 tasks
Contributor
|
🎉 This PR is included in version 6.12.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
aliatsis
pushed a commit
to creditiq/sequelize
that referenced
this pull request
Jun 2, 2022
…elize#13807) * fix(13804): use schema for ARRAY(ENUM) type name * fix(31804): Update integration test Co-authored-by: Rik Smale <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Please make sure to review and check all of these items:
npm run testornpm run test-DIALECTpass with this change (including linting)?Description Of Change
Closes #13804
This change is also realated with #13204 PR #13210. It not caused by it but the source of both bugs is the same, improper handling of ARRAY[ENUM] on postgres. In this scenario is only when we are using schemas.