meta(deps): Update retry-as-promised to 5.0.0#13785
Merged
sdepold merged 3 commits intosequelize:mainfrom Dec 21, 2021
Merged
Conversation
Earlier versions of retry-as-promised rely on any-promise which relies on a global `window` object. This change makes Sequelize a bit easier to use on node environments, especially with server side rendering like next.js
WikiRik
approved these changes
Dec 18, 2021
Contributor
|
🎉 This PR is included in version 6.12.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
aliatsis
pushed a commit
to creditiq/sequelize
that referenced
this pull request
Jun 2, 2022
Earlier versions of retry-as-promised rely on any-promise which relies on a global `window` object. This change makes Sequelize a bit easier to use on node environments, especially with server side rendering like next.js Co-authored-by: Rik Smale <[email protected]> Co-authored-by: Sascha Depold <[email protected]>
|
Looking at the diff, I wonder whether you guys really didn't have to change anything regarding this breaking change: mickhansen/retry-as-promised#26 |
|
Hm I see #13494 |
Member
|
That breaking change is retry-as-promised v3 to v4. This PR is about v4 to v5; mickhansen/retry-as-promised@v4.0.0...v5.0.0 so we didn't have to change anything |
|
Yeah sorry I meant 3 to 4. |
|
Anyway, I don't see a related change in #13729 but I guess that's ok. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Please make sure to review and check all of these items:
npm run testornpm run test-DIALECTpass with this change (including linting)?Description Of Change
Earlier versions of retry-as-promised rely on the package any-promise which depends on a global
windowobject. This change makes Sequelize a bit easier to use on node environments, especially with server side rendering like next.js