refactor(operators): convert operators to typescript#13731
Merged
Conversation
To avoid name clashes with your global symbol keys and other (library code) global symbols, it might be a good idea to prefix your symbols
Member
Author
|
Since papb no longer active maintaining directly in the repository, so I assign @sdepold to review this. |
Member
|
Could you maybe migrate this file to TypeScript as well? Otherwise we will have to change this file twice in a short time |
Member
Author
Okay, will work on it, drafted |
WikiRik
reviewed
Dec 5, 2021
fzn0x
added
the
typescript
WikiRik
reviewed
Dec 13, 2021
Member
WikiRik
left a comment
WikiRik
left a comment
There was a problem hiding this comment.
TypeScript changes look okay, but I'll leave it open for people with more experience. I do have some remarks about the other changes you made
sdepold
changed the title
Member
|
I added some last bits to the PR |
Contributor
|
🎉 This PR is included in version 6.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
5 tasks
2 tasks
This was referenced Dec 20, 2021
aliatsis
pushed a commit
to creditiq/sequelize
that referenced
this pull request
Jun 2, 2022
* refactor(operators): symbol keys prefix To avoid name clashes with your global symbol keys and other (library code) global symbols, it might be a good idea to prefix your symbols * feat: add operators.ts * feat: add operators.ts * Not an object * Change to string * refactor(operators): convert to typescript * fix(operators): revert values back to original values Co-authored-by: Sascha Depold <[email protected]> Co-authored-by: Sascha Depold <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Please make sure to review and check all of these items:
npm run testornpm run test-DIALECTpass with this change (including linting)?Description Of Change
To avoid name clashes with your global symbol keys and other (library code) global symbols, it might be a good idea to prefix your symbols
Todos