fix(query-interface): allow sequelize.fn and sequelize.literal in fields of IndexesOptions#12224
Merged
sushantdhiman merged 3 commits intosequelize:masterfrom May 8, 2020
Merged
Conversation
…lds of IndexesOptions
Codecov Report
@@ Coverage Diff @@
## master #12224 +/- ##
=======================================
Coverage 96.33% 96.33%
=======================================
Files 95 95
Lines 9118 9118
=======================================
Hits 8784 8784
Misses 334 334 Continue to review full report at Codecov.
|
SimonSchick
suggested changes
May 5, 2020
Contributor
SimonSchick
left a comment
SimonSchick
left a comment
There was a problem hiding this comment.
Missing test, you also did not fill out the PR template correctly.
Contributor
Author
I added a test for this pull request. Please check it. |
SimonSchick
approved these changes
May 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
npm run testornpm run test-DIALECTpass with this change (including linting)?Description of change
As far as I know, sequelize allows
sequelize.fnandsequelize.literalto be used forindexes.fieldswhen defining models, because I have seen that the current sequelize types seem it does not allow to do so, this pull request solves the problem.(Documented on https://sequelize.org/master/class/lib/model.js~Model.html)