Skip to content

test: remove redundant test#11156

Merged
sushantdhiman merged 1 commit intomasterfrom
test/remove-dead
Jul 6, 2019
Merged

test: remove redundant test#11156
sushantdhiman merged 1 commit intomasterfrom
test/remove-dead

Conversation

@SimonSchick
Copy link
Copy Markdown
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

These are now redundant after #11122

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 6, 2019

Codecov Report

Merging #11156 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11156      +/-   ##
==========================================
- Coverage   96.35%   96.33%   -0.02%     
==========================================
  Files          94       94              
  Lines        9015     9015              
==========================================
- Hits         8686     8685       -1     
- Misses        329      330       +1
Impacted Files Coverage Δ
lib/dialects/postgres/query-generator.js 94.29% <0%> (-0.28%) ⬇️
lib/dialects/mssql/connection-manager.js 87.01% <0%> (ø) ⬆️
lib/dialects/mssql/index.js 100% <0%> (ø) ⬆️
lib/model.js 96.69% <0%> (ø) ⬆️
lib/query-interface.js 92.21% <0%> (ø) ⬆️
lib/sequelize.js 95.91% <0%> (ø) ⬆️
lib/dialects/abstract/query-generator.js 97.59% <0%> (ø) ⬆️
...dialects/abstract/query-generator/helpers/quote.js 100% <0%> (ø) ⬆️
lib/dialects/mssql/data-types.js 100% <0%> (ø) ⬆️
lib/dialects/mssql/resource-lock.js 100% <0%> (ø) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6d6787...e3674dc. Read the comment docs.

@sushantdhiman sushantdhiman merged commit f95d26f into master Jul 6, 2019
@sushantdhiman sushantdhiman deleted the test/remove-dead branch July 6, 2019 09:57
schmod pushed a commit to schmod/sequelize that referenced this pull request Jul 10, 2019
…ndle-deadlock

* 'master' of github.com:sequelize/sequelize: (22 commits)
  docs(migrations): use timestamps with seed (sequelize#11160)
  test: remove redundant test (sequelize#11156)
  fix(types): add literal to possible where options (sequelize#10990)
  fix(model): don't alter original scopes when combining them (sequelize#10722)
  fix(types): relax order typing (sequelize#10802)
  fix(types): add string to Includeable (sequelize#11003)
  docs(models-definition): correct spelling mistakes (sequelize#11147)
  fix(types): silent option for update (sequelize#11115)
  fix: update sequelize-pool (sequelize#11134)
  feat(hooks): beforeDisconnect / afterDisconnect (sequelize#11117)
  refactor: remove unused _templateSettings
  refactor(query-generation): remove lodash string templates (sequelize#11122)
  docs: improve datatype docs
  docs: explain defaults/where behavior for find/create (sequelize#11069)
  build: remove test*.js from .gitignore (sequelize#11108)
  docs(data-types): extending types
  fix(sequelize.close): update sequelize-pool (sequelize#11101)
  build: update dependencies (sequelize#11099)
  docs(migrations): foreign key example (sequelize#11097)
  fix(mariadb): properly escape json path key (sequelize#11089)
  ...
@sushantdhiman
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 5.9.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sushantdhiman
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 7.0.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants