fix(types): Add missing silent option#11115
Merged
sushantdhiman merged 2 commits intosequelize:masterfrom Jul 2, 2019
negezor:patch-1
Merged
fix(types): Add missing silent option#11115sushantdhiman merged 2 commits intosequelize:masterfrom negezor:patch-1
sushantdhiman merged 2 commits intosequelize:masterfrom
negezor:patch-1
Conversation
<!-- Thanks for wanting to fix something on Sequelize - we already love you! Please fill in the template below. If unsure about something, just do as best as you're able. If your PR only contains changes to documentation, you may skip the template below. --> ### Pull Request check-list _Please make sure to review and check all of these items:_ - [ ] Does `npm run test` or `npm run test-DIALECT` pass with this change (including linting)? - [ ] Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving? - [ ] Have you added new tests to prevent regressions? - [ ] Is a documentation update included (if this change modifies existing APIs, or introduces new ones)? - [X] Did you follow the commit message conventions explained in [CONTRIBUTING.md](https://github.com/sequelize/sequelize/blob/master/CONTRIBUTING.md)? <!-- NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open. --> ### Description of change Add missing `silent` option <!-- Please provide a description of the change here. -->
Codecov Report
@@ Coverage Diff @@
## master #11115 +/- ##
==========================================
+ Coverage 96.34% 96.34% +<.01%
==========================================
Files 94 94
Lines 9009 9013 +4
==========================================
+ Hits 8680 8684 +4
Misses 329 329
Continue to review full report at Codecov.
|
Contributor
|
Add a super small test pls |
sushantdhiman
approved these changes
Jul 2, 2019
Contributor
|
🎉 This PR is included in version 5.9.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
schmod
pushed a commit
to schmod/sequelize
that referenced
this pull request
Jul 10, 2019
…ndle-deadlock * 'master' of github.com:sequelize/sequelize: (22 commits) docs(migrations): use timestamps with seed (sequelize#11160) test: remove redundant test (sequelize#11156) fix(types): add literal to possible where options (sequelize#10990) fix(model): don't alter original scopes when combining them (sequelize#10722) fix(types): relax order typing (sequelize#10802) fix(types): add string to Includeable (sequelize#11003) docs(models-definition): correct spelling mistakes (sequelize#11147) fix(types): silent option for update (sequelize#11115) fix: update sequelize-pool (sequelize#11134) feat(hooks): beforeDisconnect / afterDisconnect (sequelize#11117) refactor: remove unused _templateSettings refactor(query-generation): remove lodash string templates (sequelize#11122) docs: improve datatype docs docs: explain defaults/where behavior for find/create (sequelize#11069) build: remove test*.js from .gitignore (sequelize#11108) docs(data-types): extending types fix(sequelize.close): update sequelize-pool (sequelize#11101) build: update dependencies (sequelize#11099) docs(migrations): foreign key example (sequelize#11097) fix(mariadb): properly escape json path key (sequelize#11089) ...
7 tasks
Contributor
|
🎉 This PR is included in version 7.0.0-next.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
npm run testornpm run test-DIALECTpass with this change (including linting)?Description of change
Add missing
silentoption