docs: add note for find*create functions#11069
Merged
sushantdhiman merged 2 commits intosequelize:masterfrom Jun 26, 2019
levibostian:findcreate-doc
Merged
docs: add note for find*create functions#11069sushantdhiman merged 2 commits intosequelize:masterfrom levibostian:findcreate-doc
sushantdhiman merged 2 commits intosequelize:masterfrom
levibostian:findcreate-doc
Conversation
sushantdhiman
suggested changes
Jun 21, 2019
Codecov Report
@@ Coverage Diff @@
## master #11069 +/- ##
=========================================
- Coverage 96.34% 89.55% -6.8%
=========================================
Files 94 92 -2
Lines 9009 8913 -96
=========================================
- Hits 8680 7982 -698
- Misses 329 931 +602
Continue to review full report at Codecov.
|
Contributor
|
I mentioned |
Contributor
|
🎉 This PR is included in version 5.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
schmod
pushed a commit
to schmod/sequelize
that referenced
this pull request
Jul 10, 2019
…ndle-deadlock * 'master' of github.com:sequelize/sequelize: (22 commits) docs(migrations): use timestamps with seed (sequelize#11160) test: remove redundant test (sequelize#11156) fix(types): add literal to possible where options (sequelize#10990) fix(model): don't alter original scopes when combining them (sequelize#10722) fix(types): relax order typing (sequelize#10802) fix(types): add string to Includeable (sequelize#11003) docs(models-definition): correct spelling mistakes (sequelize#11147) fix(types): silent option for update (sequelize#11115) fix: update sequelize-pool (sequelize#11134) feat(hooks): beforeDisconnect / afterDisconnect (sequelize#11117) refactor: remove unused _templateSettings refactor(query-generation): remove lodash string templates (sequelize#11122) docs: improve datatype docs docs: explain defaults/where behavior for find/create (sequelize#11069) build: remove test*.js from .gitignore (sequelize#11108) docs(data-types): extending types fix(sequelize.close): update sequelize-pool (sequelize#11101) build: update dependencies (sequelize#11099) docs(migrations): foreign key example (sequelize#11097) fix(mariadb): properly escape json path key (sequelize#11089) ...
Contributor
|
🎉 This PR is included in version 7.0.0-next.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I spent a few days this week pounding my head against the wall wondering why when I would run any of the
Model.find*Create()functions, whatever I was putting into thewhereoptions parameter, it was getting inserted into the database.From reading the docs and also assuming that
whereis only used for the "WHERE" query generation, I finally dug into the source code of sequelize and realized my issue.I thought it would be helpful for others to realize when they use any of these functions that the
whereoption will be used in the create query.