Skip to content

fix: update sequelize-pool#11055

Merged
sushantdhiman merged 2 commits intomasterfrom
update-pool
Jun 11, 2019
Merged

fix: update sequelize-pool#11055
sushantdhiman merged 2 commits intomasterfrom
update-pool

Conversation

@sushantdhiman
Copy link
Copy Markdown
Contributor

@sushantdhiman sushantdhiman commented Jun 11, 2019

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Fixes #10902

Updates pool library to fix a bug with double destroy sequelize/sequelize-pool#6

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 11, 2019

Codecov Report

Merging #11055 into master will increase coverage by 0.95%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11055      +/-   ##
==========================================
+ Coverage   89.54%   90.49%   +0.95%     
==========================================
  Files          92       91       -1     
  Lines        8912     8809     -103     
==========================================
- Hits         7980     7972       -8     
+ Misses        932      837      -95
Impacted Files Coverage Δ
lib/dialects/abstract/connection-manager.js 90.35% <100%> (+0.08%) ⬆️
lib/dialects/mysql/query-generator.js 5.5% <0%> (-92.38%) ⬇️
lib/dialects/mariadb/query-generator.js 10.63% <0%> (-87.24%) ⬇️
lib/dialects/mysql/query.js 15.51% <0%> (-82.76%) ⬇️
lib/dialects/mysql/query-interface.js 21.05% <0%> (-78.95%) ⬇️
lib/dialects/mysql/connection-manager.js 29.09% <0%> (-67.28%) ⬇️
lib/dialects/mysql/data-types.js 43.75% <0%> (-54.69%) ⬇️
lib/dialects/mariadb/data-types.js 50.98% <0%> (-49.02%) ⬇️
lib/sql-string.js 82.53% <0%> (-7.94%) ⬇️
lib/sequelize.js 92.45% <0%> (-3.15%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a494ee...621ac11. Read the comment docs.

@sushantdhiman sushantdhiman merged commit dcf079b into master Jun 11, 2019
@sushantdhiman sushantdhiman deleted the update-pool branch June 11, 2019 15:53
@sushantdhiman
Copy link
Copy Markdown
Contributor Author

sushantdhiman commented Jun 11, 2019

🎉 This PR is included in version 5.8.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced Oct 26, 2019
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Increased database connections in sequelize 5

1 participant

@sushantdhiman