fix(types): add string to Includeable#11003
Merged
SimonSchick merged 2 commits intosequelize:masterfrom Jul 5, 2019
zjr:master
Merged
fix(types): add string to Includeable#11003SimonSchick merged 2 commits intosequelize:masterfrom zjr:master
SimonSchick merged 2 commits intosequelize:masterfrom
zjr:master
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11003 +/- ##
==========================================
+ Coverage 92.33% 96.34% +4.01%
==========================================
Files 91 94 +3
Lines 8727 9013 +286
==========================================
+ Hits 8058 8684 +626
+ Misses 669 329 -340
Continue to review full report at Codecov.
|
Contributor
Author
|
Travis taught me how to test the types and revealed that there was a duplicate |
Contributor
|
Pls rebase |
SimonSchick
reviewed
Jun 14, 2019
Contributor
Author
|
Sure, will try to get to it this weekend.
… On Jun 14, 2019, at 12:14 AM, Simon Schick ***@***.***> wrote:
@SimonSchick commented on this pull request.
In types/lib/sequelize.d.ts <#11003 (comment)>:
> /**
- * Alters tables to fit models. Not recommended for production use. Deletes data in columns that were removed or had their type changed in the model.
+ * If alter is true, each DAO will do ALTER TABLE ... CHANGE ...
This isn't aligned quite correctly, please fix, will merge after.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#11003?email_source=notifications&email_token=AAG7BYJOISAE7LUILMVEMUTP2MLKJA5CNFSM4HPVMBLKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB3RCNCA#pullrequestreview-249702024>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAG7BYJCJKOTVOWSGKKOPG3P2MLKJANCNFSM4HPVMBLA>.
|
Contributor
Author
|
@SimonSchick I've updated the PR. There's a new failing test since I opened it but I'm fairly certain it has nothing to do with this pull. |
sushantdhiman
approved these changes
Jun 21, 2019
Contributor
Author
|
Anything else I should do with this? |
Contributor
|
Rebase 😅 |
This is allowable for Aliases, according to docs and lack of errors when attempting. options.include: http://docs.sequelizejs.com/class/lib/model.js~Model.html#static-method-findAll
Contributor
Author
|
@SimonSchick rebased |
SimonSchick
approved these changes
Jul 5, 2019
Contributor
|
🎉 This PR is included in version 5.9.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
schmod
pushed a commit
to schmod/sequelize
that referenced
this pull request
Jul 10, 2019
…ndle-deadlock * 'master' of github.com:sequelize/sequelize: (22 commits) docs(migrations): use timestamps with seed (sequelize#11160) test: remove redundant test (sequelize#11156) fix(types): add literal to possible where options (sequelize#10990) fix(model): don't alter original scopes when combining them (sequelize#10722) fix(types): relax order typing (sequelize#10802) fix(types): add string to Includeable (sequelize#11003) docs(models-definition): correct spelling mistakes (sequelize#11147) fix(types): silent option for update (sequelize#11115) fix: update sequelize-pool (sequelize#11134) feat(hooks): beforeDisconnect / afterDisconnect (sequelize#11117) refactor: remove unused _templateSettings refactor(query-generation): remove lodash string templates (sequelize#11122) docs: improve datatype docs docs: explain defaults/where behavior for find/create (sequelize#11069) build: remove test*.js from .gitignore (sequelize#11108) docs(data-types): extending types fix(sequelize.close): update sequelize-pool (sequelize#11101) build: update dependencies (sequelize#11099) docs(migrations): foreign key example (sequelize#11097) fix(mariadb): properly escape json path key (sequelize#11089) ...
Contributor
|
🎉 This PR is included in version 7.0.0-next.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is allowable for Aliases, according to docs and lack of errors when attempting.
See Types: options.include
Pull Request check-list
Please make sure to review and check all of these items:
npm run testornpm run test-DIALECTpass with this change (including linting)?Description of change
I tried to follow what this person did at #10804 as far as tests go, but, TBH I didn't look into how these typedef tests work.
This just adds
stringas a possible type forIncludeableas is allowed for Aliases.