fix(types): relax order typing#10802
Merged
sushantdhiman merged 1 commit intosequelize:masterfrom Jul 6, 2019
Merged
Conversation
Member
|
hmm now Maybe we define explicitly up to 5 or 10 levels? Not perfect either but prevents wrong usage as shown above 🤔 |
SimonSchick
added
pr:needs test
typescript
Chocobozzz
force-pushed
the
feature/typing-order
branch
from
947be6f to
c339659
Compare
Codecov Report
@@ Coverage Diff @@
## master #10802 +/- ##
===========================================
+ Coverage 74.54% 96.35% +21.81%
===========================================
Files 85 94 +9
Lines 8186 9008 +822
===========================================
+ Hits 6102 8680 +2578
+ Misses 2084 328 -1756
Continue to review full report at Codecov.
|
Chocobozzz
force-pushed
the
feature/typing-order
branch
from
c339659 to
b6186b5
Compare
Contributor
Author
|
@eseliger Please take another look @SimonSchick I added tests |
SimonSchick
approved these changes
Apr 30, 2019
Member
|
needs rebase |
Chocobozzz
force-pushed
the
feature/typing-order
branch
from
ca97322 to
fd56e99
Compare
Contributor
Author
|
@eseliger done |
|
When can we expect this change to be merged? |
Contributor
|
🎉 This PR is included in version 5.9.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
schmod
pushed a commit
to schmod/sequelize
that referenced
this pull request
Jul 10, 2019
…ndle-deadlock * 'master' of github.com:sequelize/sequelize: (22 commits) docs(migrations): use timestamps with seed (sequelize#11160) test: remove redundant test (sequelize#11156) fix(types): add literal to possible where options (sequelize#10990) fix(model): don't alter original scopes when combining them (sequelize#10722) fix(types): relax order typing (sequelize#10802) fix(types): add string to Includeable (sequelize#11003) docs(models-definition): correct spelling mistakes (sequelize#11147) fix(types): silent option for update (sequelize#11115) fix: update sequelize-pool (sequelize#11134) feat(hooks): beforeDisconnect / afterDisconnect (sequelize#11117) refactor: remove unused _templateSettings refactor(query-generation): remove lodash string templates (sequelize#11122) docs: improve datatype docs docs: explain defaults/where behavior for find/create (sequelize#11069) build: remove test*.js from .gitignore (sequelize#11108) docs(data-types): extending types fix(sequelize.close): update sequelize-pool (sequelize#11101) build: update dependencies (sequelize#11099) docs(migrations): foreign key example (sequelize#11097) fix(mariadb): properly escape json path key (sequelize#11089) ...
Contributor
|
🎉 This PR is included in version 7.0.0-next.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
npm run testornpm run test-DIALECTpass with this change (including linting)?Description of change
Relax type
orderchecking in queries, because we can have multiple nester models and or strings etc. I'm not sure we can do better than this.Closes #10780