-
Notifications
You must be signed in to change notification settings - Fork 11
Propagate CE pre-run and post-run scripts on pipeline launch #496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hm, I've been trying to test this behaviour locally, however it works for me even before this fix (tried both the natively-compiled version from
Also, I wasn't sure whether you meant that the scripts are defined when you add a pipeline, or when you launch it, so I tested the other scenario too, where I have the scripts defined in the CE, and then overwritten when adding the pipeline. Not providing parameters from the cli: and it also worked correctly. What am I missing? |
weronikasosnowskaseqera
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @tcrespog do we want to move this forward?
Hi, @weronikasosnowskaseqera. I realized that the |
|
Hey @tcrespog - I have a PR with another version bump of the tower-java-sdk to a version that would supersede the one in this PR. |
Hi, @georgi-seqera. It is okay if you merge yours first. Thank you. |
|
@tcrespog merge conflict seems easy but can you check if additional changes are required to move this PR forward? |
Description
null).Guidelines for testing