Fix for jehiah/sortdb#4: Use actual copy operator before returning#2
Merged
Conversation
Also adds a test to ensure that writes after a Search do not modify the returned buffer (tests that a copy was actually made).
There was a problem hiding this comment.
I'd rename s to source and d to dest just for extra clarity, then the comment really isn't even necessary.
There was a problem hiding this comment.
That's not really how Go works:
- Comment required for Go Doc
- Go style prefers short names: https://github.com/golang/go/wiki/CodeReviewComments#variable-names
Author
There was a problem hiding this comment.
ping @joshgummersall -- Are you alright with this as is?
|
One quick comment, then LGTM. |
Per the Go guidelines: - More concise naming for variables that are used immediately - More descriptive naming for variables that are used further from their declarations
|
lgtm |
Author
|
sgtm |
noam-c
added a commit
that referenced
this pull request
Aug 13, 2015
Fix for jehiah#4: Use actual copy operator before returning
noam-c
pushed a commit
that referenced
this pull request
Jan 8, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also adds a test to ensure that writes after a Search do not modify the
returned buffer (tests that a copy was actually made).