Healthcheckresults #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 20, 2016 17:28
There is a typo in the url used for the tasks API call. The state parameter doesn't exist and is replaced by this commit with status, which is the correct parameter name [0]. Also fixed: A dependency pulls json > 2.0 which depends on ruby > 2.0. This breaks the 1.9.3 build, so an explicit requirement of json < 2.0 is added. [0]: https://mesosphere.github.io/marathon/docs/rest-api.html#get-v2-tasks
This change checks the health check results for each task and reports running but unhealthy tasks as failures. Previously, the health check results where ignored, only the state was considered.
5 tasks
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
This pull request fixes the second part of #9. The health checks are included in the result.
General
Purpose
Make the plugin more reliable by including Marathon's health checks in the result.
Known Compatablity Issues
None