This repository was archived by the owner on Jan 6, 2020. It is now read-only.
Replaced calls to DialogHelper with calls to QuestionHelper#321
Closed
nacmartin wants to merge 2 commits into
Closed
Replaced calls to DialogHelper with calls to QuestionHelper#321nacmartin wants to merge 2 commits into
nacmartin wants to merge 2 commits into
Conversation
Member
|
Thank you @nacmartin. |
Member
|
Thank you @nacmartin. |
fabpot
added a commit
that referenced
this pull request
Dec 7, 2014
…r (nacmartin) This PR was squashed before being merged into the 2.4.x-dev branch (closes #321). Discussion ---------- Replaced calls to DialogHelper with calls to QuestionHelper As `DialogHelper` was deprecated in 2.5, replacing calls to it with calls to `QuestionHelper` is needed. On top of it, 4 days ago a Deprecated Error was introduced in `DialogHelper`, and this causes half of the tests of this bundle to fail. This pull request fixes #320 Commits ------- 2faf7eb Replaced calls to DialogHelper with calls to QuestionHelper
fabpot
added a commit
that referenced
this pull request
Dec 7, 2014
…r (nacmartin) This PR was squashed before being merged into the 2.5.x-dev branch (closes #321). Discussion ---------- Replaced calls to DialogHelper with calls to QuestionHelper As `DialogHelper` was deprecated in 2.5, replacing calls to it with calls to `QuestionHelper` is needed. On top of it, 4 days ago a Deprecated Error was introduced in `DialogHelper`, and this causes half of the tests of this bundle to fail. This pull request fixes #320 Commits ------- 59eebd0 Replaced calls to DialogHelper with calls to QuestionHelper
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As
DialogHelperwas deprecated in 2.5, replacing calls to it with calls toQuestionHelperis needed. On top of it, 4 days ago a Deprecated Error was introduced inDialogHelper, and this causes half of the tests of this bundle to fail.This pull request fixes #320