feat: Add data residency for eu and global regions #1190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrutiburman
requested review from
gladysmae08,
manisha1997,
tbischel and
tiwarishubham635
tbischel
reviewed
Nov 27, 2023
|
|
||
| if (!REGION_HOST_MAP.ContainsKey(region)) | ||
| { | ||
| Console.WriteLine("Region can only be 'global' or 'eu'."); |
Contributor
There was a problem hiding this comment.
should this be an exception?
tbischel
requested changes
Nov 27, 2023
Contributor
tbischel
left a comment
tbischel
left a comment
There was a problem hiding this comment.
It looks like you've updated the use case file, but should we also update the "examples" directory to include something for data residency?
Contributor
Author
Right, added a file in /examples. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
This PR:
Adds a setter setDataResidency() which allows the users to switch to EU sub region, reidrecting their requests to api.eu.sendgrid.com
Also, ran
dotnet formatto fix some files.Checklist
If you have questions, please file a support ticket, or create a GitHub Issue in this repository.