fix: Use httpErrorAsException when passed as parameter to SendGridClient constructor #1180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mortenbock
changed the title
Contributor
Author
|
Well that's awkward. Apparently I did not run a compile before pushing. But I think this would result in the same issue as when the optional parameter was added? I'm not sure what the best approach is here. I could change the order of the optional parameters maybe for the new overload? |
mortenbock
force-pushed
the
fix/use-constructor-parameter
branch
from
7d1868e to
f3b7004
Compare
Contributor
Author
|
I changed the overload to avoid conflicting signatures. |
mortenbock
force-pushed
the
fix/use-constructor-parameter
branch
from
f3b7004 to
0a44588
Compare
Contributor
childish-sambino
left a comment
childish-sambino
left a comment
There was a problem hiding this comment.
🥇 Thanks for the fix!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
When passing
httpErrorAsExceptionas a parameter to theSendGridClientconstructor, it was not used for anything. This PR passes the value the the options object created.Checklist