Skip to content

feat: Added mail settings attributes for bypass_spam_management, bypass_bou… #1153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rakatyal merged 7 commits into from
Mar 10, 2022
Merged

feat: Added mail settings attributes for bypass_spam_management, bypass_bou… #1153

rakatyal merged 7 commits into from
Mar 10, 2022

Conversation

@asos-vinodpatil
Copy link
Contributor

@asos-vinodpatil asos-vinodpatil commented Jan 7, 2022 •
edited
Loading

…nce_management and bypass_unsubscribe_management

#1135

Fixes

A short description of what this PR does.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

JenniferMah
JenniferMah reviewed Jan 11, 2022
View reviewed changes
Copy link
Contributor

@JenniferMah JenniferMah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @asos-vinodpatil! Thanks for your PR! Would you mind adding some documentation for spam, bounce, and unsubscribe bypass management filters in the Usage.md and Use_cases.md? Here's an example of the documentation in php.

@asos-vinodpatil
Copy link
Contributor Author

asos-vinodpatil commented Jan 11, 2022

Hi @asos-vinodpatil! Thanks for your PR! Would you mind adding some documentation for spam, bounce, and unsubscribe bypass management filters in the Usage.md and Use_cases.md? Here's an example of the documentation in php.

Thanks @JenniferMah, added required documentation.

@asos-vinodpatil
Copy link
Contributor Author

asos-vinodpatil commented Jan 25, 2022

@JenniferMah Any update on this PR

@shwetha-manvinkurke shwetha-manvinkurke changed the title Added mail settings attributes for bypass_spam_management, bypass_bou… feat: Added mail settings attributes for bypass_spam_management, bypass_bou… Feb 2, 2022
shwetha-manvinkurke
shwetha-manvinkurke reviewed Feb 2, 2022
View reviewed changes
@rakatyal
Copy link
Contributor

rakatyal commented Mar 10, 2022

Thank you for the PR. LGTM!

@rakatyal rakatyal merged commit 5ed9472 into sendgrid:main Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rakatyal rakatyal rakatyal approved these changes

@JenniferMah JenniferMah Awaiting requested review from JenniferMah

@shwetha-manvinkurke shwetha-manvinkurke Awaiting requested review from shwetha-manvinkurke

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@asos-vinodpatil @rakatyal @shwetha-manvinkurke @JenniferMah