Skip to content

Add NullAway checks#317

Merged
piotrooo merged 1 commit intosemver4j:mainfrom
mk868:nullaway
Jan 21, 2025
Merged

Add NullAway checks#317
piotrooo merged 1 commit intosemver4j:mainfrom
mk868:nullaway

Conversation

@mk868
Copy link
Copy Markdown
Contributor

@mk868 mk868 commented Dec 30, 2024

Related: #312

Changes in this PR:

  • A new Maven profile nullaway added
  • Analysis with Java 23 added to the CI - the latest version of java contains the most fixes

@xenoterracide
Copy link
Copy Markdown

xenoterracide commented Jan 6, 2025

I'm not certain that it's a good idea to use jspecify mode yet, I think that's pretty significantly under development. YMMV, but jspecify mode isn't needed just because you're using those annotations. On the other hand, if it works... was looking at this PR for a different reason anyways.

@mk868
Copy link
Copy Markdown
Contributor Author

mk868 commented Jan 7, 2025

Thank you for pointing that out!
I'm aware that the logic under this flag is still under development.
For me, enabling JSpecifyMode is a way to contribute to the community, any unexpected behavior we encounter in NullAway can be reported to its creators to help improve the tool.
Since this is a build-time tool, it's safe for the semver4j project - if critical issues occur with the tool, we can simply remove the -XepOpt:NullAway:JSpecifyMode=true flag.

@piotrooo WDYT?

@piotrooo piotrooo added the enhancement New feature or request label Jan 15, 2025
@piotrooo
Copy link
Copy Markdown
Member

For me, it's ok. I saw a couple of projects that moved to JSpecify. I think it's a good move.

Comment thread .github/workflows/ci.yml
@piotrooo piotrooo merged commit b8b05b2 into semver4j:main Jan 21, 2025
@piotrooo piotrooo linked an issue Jan 21, 2025 that may be closed by this pull request
@mk868 mk868 deleted the nullaway branch January 21, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a NullAway analysis

3 participants