You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm not certain that it's a good idea to use jspecify mode yet, I think that's pretty significantly under development. YMMV, but jspecify mode isn't needed just because you're using those annotations. On the other hand, if it works... was looking at this PR for a different reason anyways.
Thank you for pointing that out!
I'm aware that the logic under this flag is still under development.
For me, enabling JSpecifyMode is a way to contribute to the community, any unexpected behavior we encounter in NullAway can be reported to its creators to help improve the tool.
Since this is a build-time tool, it's safe for the semver4j project - if critical issues occur with the tool, we can simply remove the -XepOpt:NullAway:JSpecifyMode=true flag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #312
Changes in this PR:
nullawayadded