Reworking range processors to short-circuit when a suitable parsed range is found#258
Merged
piotrooo merged 10 commits intosemver4j:mainfrom Sep 14, 2024
Merged
Conversation
…lZeroProcessor to not look for Ivy-specific range strings and to return null if no match is found
…ch is found; Converted RangeProcessorPipeline to use new tryProcess() function from Processor implementations
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #258 +/- ##
============================================
+ Coverage 92.17% 92.89% +0.72%
- Complexity 268 272 +4
============================================
Files 21 22 +1
Lines 639 676 +37
Branches 103 105 +2
============================================
+ Hits 589 628 +39
Misses 17 17
+ Partials 33 31 -2 ☔ View full report in Codecov by Sentry. |
…precated; Added AllVersionsProcessor to encapsulate new behavior for non-Ivy "all versions" range strings; Memoized RangeProcessorPipeline in RangesString; Added missing test case in CaretProcessorTest
piotrooo
approved these changes
Sep 14, 2024
Member
piotrooo
left a comment
piotrooo
left a comment
There was a problem hiding this comment.
Sorry for the HUGE delay 🙏. It looks nice. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
latestandlatest.integrationprocessing have been moved into IvyProcessor such that all range string processors should now be self-containedThis fixes #257