Conversion of internal package classes to use static only#240
Merged
piotrooo merged 5 commits intosemver4j:mainfrom Apr 17, 2024
Merged
Conversion of internal package classes to use static only#240piotrooo merged 5 commits intosemver4j:mainfrom
piotrooo merged 5 commits intosemver4j:mainfrom
Conversation
… refinements of Coerce to directly use pattern-matching string as well as Optional for parsing nullable values
piotrooo
added
enhancement
piotrooo
requested changes
Apr 10, 2024
Member
piotrooo
left a comment
piotrooo
left a comment
There was a problem hiding this comment.
A few comments; generally, I like the idea of this refactor.
# Conflicts: # src/main/java/org/semver4j/internal/Comparator.java
piotrooo
approved these changes
Apr 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal package classes are now containers of pure functions; Slight refinements of Coerce to directly use pattern-matching string as well as Optional for parsing nullable values
Fixes #239