Skip to content

Using longs to parse identifiers instead of ints to avoid issues when parsing timestamp-sized values#230

Merged
piotrooo merged 1 commit intosemver4j:mainfrom
severn-everett:prerelease_nfe
Apr 5, 2024
Merged

Using longs to parse identifiers instead of ints to avoid issues when parsing timestamp-sized values#230
piotrooo merged 1 commit intosemver4j:mainfrom
severn-everett:prerelease_nfe

Conversation

@severn-everett
Copy link
Copy Markdown
Contributor

Fixes #208

@piotrooo piotrooo added the bug Something isn't working label Apr 5, 2024
@piotrooo piotrooo merged commit 810d265 into semver4j:main Apr 5, 2024
@piotrooo
Copy link
Copy Markdown
Member

piotrooo commented Apr 5, 2024

LGTM!
Many thanks!

@severn-everett severn-everett deleted the prerelease_nfe branch April 9, 2024 14:20
@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.17%. Comparing base (7640bcf) to head (a3b6201).
Report is 65 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #230   +/-   ##
=========================================
  Coverage     92.17%   92.17%           
  Complexity      268      268           
=========================================
  Files            21       21           
  Lines           639      639           
  Branches        103      103           
=========================================
  Hits            589      589           
  Misses           17       17           
  Partials         33       33           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

java.lang.NumberFormatException

3 participants