Document coerce returning null on invalid version#197
Merged
piotrooo merged 2 commits intosemver4j:mainfrom Nov 29, 2023
Merged
Document coerce returning null on invalid version#197piotrooo merged 2 commits intosemver4j:mainfrom
coerce returning null on invalid version#197piotrooo merged 2 commits intosemver4j:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #197 +/- ##
=========================================
Coverage 91.54% 91.54%
Complexity 266 266
=========================================
Files 21 21
Lines 639 639
Branches 103 103
=========================================
Hits 585 585
Misses 19 19
Partials 35 35 ☔ View full report in Codecov by Sentry. |
Member
|
Good catch! I've also added the missing test. Many thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the README:
I believe this has changed, since running:
produces
coerce == null.This PR matches the
coerceexample with the one fromparse, and removes the mention toSemverException.