Add admin permission check for project restore from backup#3695
Merged
fiftin merged 3 commits intosemaphoreui:developfrom Mar 24, 2026
Merged
Conversation
fiftin
reviewed
Mar 23, 2026
api/projects/backup_restore.go
Outdated
| user := helpers.GetFromContext(r, "user").(*db.User) | ||
|
|
||
| if !user.Admin && !util.Config.NonAdminCanCreateProject { | ||
| log.Warn(user.Username + " is not permitted to edit users") |
Collaborator
There was a problem hiding this comment.
It looks like this message incorrect
Contributor
Author
There was a problem hiding this comment.
Hi @fiftin , I updated the message text in the log.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Title
Add admin permission check for project restore from backup
Description
This PR adds a missing admin permission check when restoring a project from backup.
Problem
In the current implementation, creating a new project correctly requires admin privileges.
However, the project restore from backup endpoint did not perform the same permission check.
As a result, a non-admin user could restore a project from a backup and effectively create a new project without having the required permissions.
This created a permission bypass scenario:
Solution
This PR adds the same admin permission validation used in project creation to the project restore operation.
Now:
Result