docs: be clear about what module of semantic-release handles updating the package.json #1601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the package.json
gr2m
reviewed
Jul 12, 2020
gr2m
approved these changes
Jul 12, 2020
Member
gr2m
left a comment
gr2m
left a comment
There was a problem hiding this comment.
Thanks a lot Gavin, that makes it more clear 👍
aquariuslt
pushed a commit
to aquariuslt/semantic-release
that referenced
this pull request
Sep 15, 2020
Collaborator
|
🎉 This PR is included in version 17.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discovered (the hard way) #1593 the package semantic-release does not update the
package.jsonits the modulesemantic-release/npmthat does. This improves the documentation to avoid any ambiguity.fixes #1593