Skip to content

fix: use correct ci branch context #1521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gr2m merged 6 commits into from
Jun 25, 2020
Merged

fix: use correct ci branch context #1521

gr2m merged 6 commits into from
Jun 25, 2020

Conversation

@iamogbz
Copy link
Contributor

@iamogbz iamogbz commented Apr 11, 2020 •
edited
Loading

Tried testing in circleci and got this message

This test run was triggered on the branch undefined, while semantic-release is configured to only publish from publish-e2e, therefore a new version won’t be published.

Note the undefined in the message above

In the env-ci package there are distinct properties that need to be used to the get the correct ci branch context
https://github.com/pvdlg/env-ci/blob/73299d7f729971a2725cff8b582367f108cfb5ea/services/circleci.js#L21-L24

@poteirard
Copy link

poteirard commented Jun 25, 2020

Any chance we can merge this? I'm having the same issue in CircleCI. Thanks for the contribution ❤️ /cc @gr2m

gr2m
gr2m approved these changes Jun 25, 2020
View reviewed changes
Copy link
Member

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good thank you!

@gr2m gr2m merged commit 0f0c650 into semantic-release:master Jun 25, 2020
@semantic-release-bot
Copy link
Collaborator

semantic-release-bot commented Jun 25, 2020

🎉 This PR is included in version 17.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gr2m gr2m mentioned this pull request Jun 25, 2020
Closed
@iamogbz iamogbz deleted the patch-1 branch June 26, 2020 02:35
@dcneiner dcneiner mentioned this pull request Jul 10, 2020
Closed
aquariuslt pushed a commit to aquariuslt/semantic-release that referenced this pull request Sep 15, 2020
@iamogbz
fix: use correct ci branch context (semantic-release#1521)
073a51f
@abbottdev abbottdev mentioned this pull request Dec 23, 2020
Closed
This was referenced Mar 10, 2021
Open
Open
Closed
Closed
Open
Open
Closed
Closed
Closed
Open
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gr2m gr2m gr2m approved these changes

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@iamogbz @poteirard @semantic-release-bot @gr2m