Skip to content

fix(deps): update dependency conventional-changlog-writer to v7#529

Merged
travi merged 2 commits intobetafrom
writer-to-beta
Sep 12, 2023
Merged

fix(deps): update dependency conventional-changlog-writer to v7#529
travi merged 2 commits intobetafrom
writer-to-beta

Conversation

@travi
Copy link
Copy Markdown
Member

@travi travi commented Sep 6, 2023

No description provided.

@travi
Copy link
Copy Markdown
Member Author

travi commented Sep 6, 2023

integration test "Exclude commits if they have a matching revert commits" fails because it appears the handling of revert commits no longer works the same as the previous major version.

there are additional failures from unit tests because i have not yet solved the comparison of the transform function in the beta branch that this pr is branched from. those can be ignored for the purpose that this pr is targeting.

…ional-changelog expectations

based on conventional-changelog/conventional-changelog#1121 (comment). however, assuming the previous order actually aligned with how core provides the list, this will need to be coordinated with reversing that list somewhere
@travi
Copy link
Copy Markdown
Member Author

travi commented Sep 10, 2023

got the integration test passing by reversing the list of commits to match the conventional-changelog expectations based on conventional-changelog/conventional-changelog#1121 (comment). however, assuming the previous order actually aligned with how core provides the list, this will need to be coordinated with reversing that list somewhere

@travi
Copy link
Copy Markdown
Member Author

travi commented Sep 12, 2023

merging since the remaining failing tests are related to the writerOpts, not the writer package

@travi travi marked this pull request as ready for review September 12, 2023 01:35
@travi travi merged commit 8e79828 into beta Sep 12, 2023
@travi travi deleted the writer-to-beta branch September 12, 2023 01:36
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 12.0.0-beta.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 12.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant