fix: failing release due to renamed repository#878
Conversation
…tory name has been changed"`
gr2m
left a comment
There was a problem hiding this comment.
Just a few nits but otherwise good to go
|
🎉 This issue has been resolved in version 10.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@gr2m breaking change...just because we have an https:// URL in our |
|
@gr2m also I can't seem to make this error go away. The |
|
|
||
| export function EMISMATCHGITHUBURL() { | ||
| return { | ||
| message: "The git repository URL mismatches the GitHub URL.", |
There was a problem hiding this comment.
@gr2m @babblebey it would be a lot more convenient to include the two values that didn't match in an error message like this
This Pull request introduces an extra step in the plugin
verifylifecycle which verifies that therepositoryUrland/or project package.json'srepositoryfield matches the project's current GitHub URL. This throws an errorEMISMATCHGITHUBURLwhich confirms mismatch and suggests a fix.Changes Made
Added a logic that requests the repo details leveraging the github get-a-repository endpoint, and checks for a
statusof200and a match between the response data'sclone_urlvalue and thecontext.options.repositoryUrl. And it should only run this when we agithubTokenis authenticated and we do not have theEINVALIDPROXYandEMISSINGREPOerror.Added a new error helper function
EMISMATCHGITHUBURLfor theRelated Issue
Fixes #803
Screencast/Screenshot
screencast-bpconcjcammlapcogcnnelfmaeghhagj-2024.07.14-11_29_00.webm