fix(throttling): use Octokit's plugin-throttling instead of a custom implementation#480
Closed
oscard0m wants to merge 2 commits intosemantic-release:masterfrom
Closed
fix(throttling): use Octokit's plugin-throttling instead of a custom implementation#480oscard0m wants to merge 2 commits intosemantic-release:masterfrom
oscard0m wants to merge 2 commits intosemantic-release:masterfrom
Conversation
achingbrain
added a commit
to achingbrain/github
that referenced
this pull request
Apr 8, 2022
Refactors the client to use [@octokit/plugin-retry](https://www.npmjs.com/package/@octokit/plugin-retry) and [@octokit/plugin-throttling](https://www.npmjs.com/package/@octokit/plugin-throttling) as GitHub occasionally changes it's API and these plugins can abstract those changes away from this module. - Removes `lib/definitions/rate-limit.js` - Adds `lib/definitions/retry.js` and `lib/definitions/throttle.js` to handle retry/throttle settings - Updates tests to be more like GitHub (returing the correct rate limit response headers, etc) Fixes semantic-release#299 and semantic-release/semantic-release#2204 See also semantic-release#480 and semantic-release#378
…throttling implementation
oscard0m
force-pushed
the
use-octokit-plugin-throttling
branch
3 times, most recently
from
74e7752 to
e4d583e
Compare
…throttling implementation
oscard0m
force-pushed
the
use-octokit-plugin-throttling
branch
from
e4d583e to
7959645
Compare
Contributor
Author
Closing this PR in favor of #487 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📓 Description
Use Octokit's throttling plugin instead of implementing a custom implementation.
❓ Unknowns
🔌 Context
The idea is to fix current throttling problems and rely on Octokit's plugin for future throttling options that could occur.