Skip to content

semantic-release/github's CI config is not properly enforcing code format #890

Description

@jedwards1211

I noticed after committing changes to my PR #886 that master seems to not be properly formatted.

The problem is the test script runs lint:*, which includes lint:prettier:fix, so invalid format can get autofixed in CI instead of erroring out. CI should error out so that no format-only changes wind up in the commit history for master.

How do you want me to fix this? I could either replace lint:* with lint:prettier, lint:lockfile etc (excluding lint:prettier:fix), or I could rename lint:prettier:fix to prettier:fix.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions