#10812 don't allow selecting a disabled option (#10814)

asolntsev · diemol · web-flow · commit ff88671fb8cb · 2022-08-30T09:24:40.000+02:00
Co-authored-by: Diego Molina &lt;diemol@users.noreply.github.com&gt;
diff --git a/java/src/org/openqa/selenium/support/ui/Select.java b/java/src/org/openqa/selenium/support/ui/Select.java
@@ -109,6 +109,8 @@ public WebElement getFirstSelectedOption() {
    */
   @Override
   public void selectByVisibleText(String text) {
+    assertSelectIsEnabled();
+
     // try to find the option via XPATH ...
     List<WebElement> options =
       element.findElements(By.xpath(".//option[normalize-space(.) = " + Quotes.escape(text) + "]"));
@@ -173,6 +175,7 @@ private String getLongestSubstringWithoutSpace(String s) {
    */
   @Override
   public void selectByIndex(int index) {
+    assertSelectIsEnabled();
     setSelectedByIndex(index, true);
   }
 
@@ -187,6 +190,7 @@ public void selectByIndex(int index) {
    */
   @Override
   public void selectByValue(String value) {
+    assertSelectIsEnabled();
     for (WebElement option : findOptionsByValue(value)) {
       setSelected(option, true);
       if (!isMultiple()) {
@@ -311,11 +315,24 @@ private void setSelectedByIndex(int index, boolean select) {
    *          deselected (false)
    */
   private void setSelected(WebElement option, boolean select) {
+    assertOptionIsEnabled(option, select);
     if (option.isSelected() != select) {
       option.click();
     }
   }
 
+  private void assertOptionIsEnabled(WebElement option, boolean select) {
+    if (select && !option.isEnabled()) {
+      throw new UnsupportedOperationException("You may not select a disabled option");
+    }
+  }
+
+  private void assertSelectIsEnabled() {
+    if (!element.isEnabled()) {
+      throw new UnsupportedOperationException("You may not select an option in disabled select");
+    }
+  }
+
   @Override
   public boolean equals(Object o) {
     if (!(o instanceof Select)) {
diff --git a/java/test/org/openqa/selenium/support/ui/SelectTest.java b/java/test/org/openqa/selenium/support/ui/SelectTest.java
@@ -20,6 +20,7 @@
 import static java.util.Collections.emptyList;
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.assertj.core.api.Assertions.assertThatExceptionOfType;
+import static org.assertj.core.api.Assertions.assertThatThrownBy;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.never;
 import static org.mockito.Mockito.verify;
@@ -74,6 +75,7 @@ private WebElement mockSelectWebElement(String multiple) {
     final WebElement element = mock(WebElement.class);
     when(element.getTagName()).thenReturn("select");
     when(element.getDomAttribute("multiple")).thenReturn(multiple);
+    when(element.isEnabled()).thenReturn(true);
     return element;
   }
 
@@ -93,12 +95,14 @@ public void shouldReturnAllOptionsWhenAsked() {
 
   private WebElement mockOption(String name, boolean isSelected) {
     final WebElement optionBad = mock(WebElement.class, name);
+    when(optionBad.isEnabled()).thenReturn(true);
     when(optionBad.isSelected()).thenReturn(isSelected);
     return optionBad;
   }
 
   private WebElement mockOption(String name, boolean isSelected, int index) {
     WebElement option = mockOption(name, isSelected);
+    when(option.isEnabled()).thenReturn(true);
     when(option.getAttribute("index")).thenReturn(String.valueOf(index));
     return option;
   }
@@ -151,6 +155,40 @@ public void shouldAllowOptionsToBeSelectedByVisibleText() {
     verify(firstOption).click();
   }
 
+  @Test
+  public void shouldNotAllowDisabledOptionsToBeSelected() {
+    final WebElement firstOption = mockOption("first", false);
+    when(firstOption.isEnabled()).thenReturn(false);
+
+    final WebElement element = mockSelectWebElement("multiple");
+    when(element.findElements(By.xpath(".//option[normalize-space(.) = \"fish\"]")))
+        .thenReturn(Collections.singletonList(firstOption));
+
+    Select select = new Select(element);
+    assertThatThrownBy(() -> select.selectByVisibleText("fish"))
+      .isInstanceOf(UnsupportedOperationException.class)
+      .hasMessage("You may not select a disabled option");
+
+    verify(firstOption, never()).click();
+  }
+
+  @Test
+  public void shouldNotAllowOptionsToBeSelectedInDisabledSelect() {
+    final WebElement firstOption = mockOption("first", false);
+
+    final WebElement element = mockSelectWebElement("multiple");
+    when(element.isEnabled()).thenReturn(false);
+    when(element.findElements(By.xpath(".//option[normalize-space(.) = \"fish\"]")))
+        .thenReturn(Collections.singletonList(firstOption));
+
+    Select select = new Select(element);
+    assertThatThrownBy(() -> select.selectByVisibleText("fish"))
+      .isInstanceOf(UnsupportedOperationException.class)
+      .hasMessage("You may not select an option in disabled select");
+
+    verify(firstOption, never()).click();
+  }
+
   @Test
   public void shouldAllowOptionsToBeSelectedByIndex() {
     final WebElement firstOption = mockOption("first", true, 0);
@@ -252,6 +290,7 @@ public void shouldFallBackToSlowLooksUpsWhenGetByVisibleTextFailsAndThereIsASpac
     when(element.findElements(xpath1)).thenReturn(emptyList());
     when(element.findElements(xpath2)).thenReturn(Collections.singletonList(firstOption));
     when(firstOption.getText()).thenReturn("foo bar");
+    when(firstOption.isEnabled()).thenReturn(true);
 
     Select select = new Select(element);
     select.selectByVisibleText("foo bar");
