[py] fix: SecurityError: Invalid Domain problem (#10653)

SinghHrmn · web-flow · commit ff19ab8bdcff · 2022-05-20T13:07:21.000+01:00
* [py] fix: Fixed the Invalid Domain error while executing JS 

- Fixed the Invalid Domain error while executing JS in Virtual
Authenticator tests.
- Added more tests for Virtual Authenticator.
- Updated SimpleWebserver to use 'localhost' instead of '127.0.0.1'
- added tests for removing credential using bytearray
- replaced Int8Array with Uint8Array in registercredential return
  since python bytearray accepts range(0,256)
diff --git a/common/src/web/virtual-authenticator.html b/common/src/web/virtual-authenticator.html
@@ -19,7 +19,6 @@ <h1>Virtual Authenticator Tests</h1>
       options=Object.assign({
         authenticatorSelection: {
           requireResidentKey: false,
-          userVerification: 'preferred'
         },
         rp: {
           id: "localhost",
@@ -41,7 +40,7 @@ <h1>Virtual Authenticator Tests</h1>
           status: "OK",
           credential: {
             id: credential.id,
-            rawId: Array.from(new Int8Array(credential.rawId)),
+            rawId: Array.from(new Uint8Array(credential.rawId)),
             transports: credential.response.getTransports(),
           }
         };
@@ -62,7 +61,7 @@ <h1>Virtual Authenticator Tests</h1>
         return {
           status: "OK",
           attestation: {
-            userHandle: new Int8Array(attestation.response.userHandle),
+            userHandle: new Uint8Array(attestation.response.userHandle),
           },
         };
       } catch(error) {
diff --git a/py/conftest.py b/py/conftest.py
@@ -187,8 +187,8 @@ def pytest_exception_interact(node, call, report):
 @pytest.fixture
 def pages(driver, webserver):
     class Pages:
-        def url(self, name):
-            return webserver.where_is(name)
+        def url(self, name, localhost=False):
+            return webserver.where_is(name, localhost)
 
         def load(self, name):
             driver.get(self.url(name))
diff --git a/py/selenium/webdriver/common/virtual_authenticator.py b/py/selenium/webdriver/common/virtual_authenticator.py
@@ -223,12 +223,12 @@ def to_dict(self):
 
     @classmethod
     def from_dict(cls, data):
-        _id = urlsafe_b64decode(data['credentialId'])
+        _id = urlsafe_b64decode(f"{data['credentialId']}==")
         is_resident_credential = bool(data['isResidentCredential'])
-        rp_id = str(data['rpId'])
-        private_key = urlsafe_b64decode(data['privateKey'])
+        rp_id = data.get('rpId', None)
+        private_key = urlsafe_b64decode(f"{data['privateKey']}==")
         sign_count = int(data['signCount'])
-        user_handle = urlsafe_b64decode(data['userHandle']) \
+        user_handle = urlsafe_b64decode(f"{data['userHandle']}==") \
             if data.get('userHandle', None) else None
 
         return cls(_id, is_resident_credential, rp_id, user_handle, private_key, sign_count)
diff --git a/py/selenium/webdriver/remote/webdriver.py b/py/selenium/webdriver/remote/webdriver.py
@@ -28,7 +28,7 @@
 import warnings
 
 from abc import ABCMeta
-from base64 import b64decode
+from base64 import b64decode, urlsafe_b64encode
 from contextlib import asynccontextmanager, contextmanager
 
 from .bidi_connection import BidiConnection
@@ -1612,21 +1612,21 @@ def _get_cdp_details(self):
         return version, websocket_url
 
     # Virtual Authenticator Methods
-    def add_virtual_authenticator(self, options: VirtualAuthenticatorOptions):
+    def add_virtual_authenticator(self, options: VirtualAuthenticatorOptions) -> None:
         """
         Adds a virtual authenticator with the given options.
         """
         self._authenticator_id = self.execute(Command.ADD_VIRTUAL_AUTHENTICATOR, options.to_dict())['value']
 
     @property
-    def virtual_authenticator_id(self):
+    def virtual_authenticator_id(self) -> str:
         """
         Returns the id of the virtual authenticator.
         """
         return self._authenticator_id
 
     @required_virtual_authenticator
-    def remove_virtual_authenticator(self):
+    def remove_virtual_authenticator(self) -> None:
         """
         Removes a previously added virtual authenticator. The authenticator is no
         longer valid after removal, so no methods may be called.
@@ -1635,7 +1635,7 @@ def remove_virtual_authenticator(self):
         self._authenticator_id = None
 
     @required_virtual_authenticator
-    def add_credential(self, credential: Credential):
+    def add_credential(self, credential: Credential) -> None:
         """
         Injects a credential into the authenticator.
         """
@@ -1645,33 +1645,36 @@ def add_credential(self, credential: Credential):
         )
 
     @required_virtual_authenticator
-    def get_credentials(self):
+    def get_credentials(self) -> List[Credential]:
         """
         Returns the list of credentials owned by the authenticator.
         """
         credential_data = self.execute(Command.GET_CREDENTIALS, {'authenticatorId': self._authenticator_id})
-        print("Get_Credential from authenticator", credential_data)
-        return credential_data['value']
+        return [Credential.from_dict(credential) for credential in credential_data['value']]
 
     @required_virtual_authenticator
-    def remove_credential(self, credential_id: str):
+    def remove_credential(self, credential_id: Union[str, bytearray]) -> None:
         """
         Removes a credential from the authenticator.
         """
+        # Check if the credential is bytearray converted to b64 string
+        if type(credential_id) is bytearray:
+            credential_id = urlsafe_b64encode(credential_id).decode()
+
         self.execute(
             Command.REMOVE_CREDENTIAL,
             {'credentialId': credential_id, 'authenticatorId': self._authenticator_id}
         )
 
     @required_virtual_authenticator
-    def remove_all_credentials(self):
+    def remove_all_credentials(self) -> None:
         """
         Removes all credentials from the authenticator.
         """
         self.execute(Command.REMOVE_ALL_CREDENTIALS, {'authenticatorId': self._authenticator_id})
 
     @required_virtual_authenticator
-    def set_user_verified(self, verified: bool):
+    def set_user_verified(self, verified: bool) -> None:
         """
         Sets whether the authenticator will simulate success or fail on user verification.
         verified: True if the authenticator will pass user verification, False otherwise.
diff --git a/py/test/selenium/webdriver/common/virtual_authenticator_tests.py b/py/test/selenium/webdriver/common/virtual_authenticator_tests.py
diff --git a/py/test/selenium/webdriver/common/webserver.py b/py/test/selenium/webdriver/common/webserver.py
